"Important line height in style attributes is wide enough" [78fd32] : Use the correct property in Test Case - Githubissues

act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML

https://act-rules.github.io/

Other

136 stars 68 forks source link

"Important line height in style attributes is wide enough" [78fd32] : Use the correct property in Test Case #2136

Closed Jym77 closed 10 months ago

Jym77 commented 10 months ago

Use the line-height property in the rule about line-height… 🙃

Marking as "Priority" since it breaks implementation reports that only run the specified procedure(s) on each rule.

Closes issue(s):

N/A

Need for Call for Review: This will not require a Call for Review (fixing a big mistake in a test case)

Pull Request Etiquette

When creating PR:

[X] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[X] Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

[X] Add yourself (and co-authors) as "Assignees" for PR.
[X] Add label to indicate if it's a Rule, Definition or Chore.
[ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
[X] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

[ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.