Need for Call for Review:
<< choose one of the following and remove the rest >>
<< check Process Document on Call for Review >>
This can be merged with 1 approval << choose reason: editorial changes to website/test code, adding new contributor, other (explain). >>
This will not require a Call for Review << choose reason(s): editorial changes (including to the applicability, expectation or examples section), changes to assumptions, background, accessibility support, change to website/test code (not rule), other (explain). >>
This will require a 1 week Call for Review << small changes affecting a small number of test cases, if in doubt do not use this. >>
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>
Pull Request Etiquette
When creating PR:
[ ] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[ ] Make sure you do not remove the "How to Review and Approve" section in your pull request description
After creating PR:
[ ] Add yourself (and co-authors) as "Assignees" for PR.
[ ] Add label to indicate if it's a Rule, Definition or Chore.
[ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".
When merging a PR:
[ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.
How to Review And Approve
Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
<< Describe the changes >>
Closes issue(s):
Need for Call for Review: << choose one of the following and remove the rest >> << check Process Document on Call for Review >> This can be merged with 1 approval << choose reason: editorial changes to website/test code, adding new contributor, other (explain). >> This will not require a Call for Review << choose reason(s): editorial changes (including to the applicability, expectation or examples section), changes to assumptions, background, accessibility support, change to website/test code (not rule), other (explain). >> This will require a 1 week Call for Review << small changes affecting a small number of test cases, if in doubt do not use this. >> This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve