Add a definition for "ARIA attribute is set", with variations whether it comes from an explicit aria-* attribute, an implicit HTML AAM, or a default value.
Switch "role has all required ARIA attributes" to also apply to implicit roles. These normally have implicitly set attributes (which is why we skipped them initially), and can now be handled by this definition.
Switch "role has all required ARIA attributes" to accept attributes set in any way.
Switch "ARIA attribute permitted" to only look at explicitly set ones. It was more or less already doing that by looking at aria-* HTML attributes, this makes it a bit clearer.
Closes issue(s):
closes #2138
Need for Call for Review:
This will require a 2 weeks Call for Review (significant changes to Applicability)
Pull Request Etiquette
When creating PR:
[x] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[x] Make sure you do not remove the "How to Review and Approve" section in your pull request description
After creating PR:
[x] Add yourself (and co-authors) as "Assignees" for PR.
[x] Add label to indicate if it's a Rule, Definition or Chore.
[x] Optionally request feedback from anyone in particular by assigning them as "Reviewers".
When merging a PR:
[ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.
How to Review And Approve
Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Carlos Duarte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.
aria-*
attribute, an implicit HTML AAM, or a default value.aria-*
HTML attributes, this makes it a bit clearer.Closes issue(s):
Need for Call for Review: This will require a 2 weeks Call for Review (significant changes to Applicability)
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve