"Text has minimum contrast" [afw4f7] and "Text has enhanced contrast" [09o5cg]: updated scenario for non-text content

giacomo-petri commented 5 months ago

The current example in Text has minimum contrast and Text has enhanced contrast "----=====++++++++___***%%%%%%%%%%%±±±±@@@@@@@@" does not depict a realistic scenario.

I have updated the example by incorporating a button featuring an "X" symbol to enhance clarity regarding the specific test's intention. Additionally, I have included a reference to 1.4.11 Non-Text content for further tests.

Closes issue(s):

closes #2132

Need for Call for Review: This will require a 1 week Call for Review

Pull Request Etiquette

When creating PR:

[ ] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[ ] Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

[ ] Add yourself (and co-authors) as "Assignees" for PR.
[ ] Add label to indicate if it's a Rule, Definition or Chore.
[ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
[ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

[ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Jym77 commented 5 months ago

Looks good. Not approving since there is already one approval from Siteimprove.

giacomo-petri commented 4 months ago

Call for review ends on February 21st.

Jym77 commented 4 months ago

@giacomo-petri I seem to be unable to solve the merge conflict myself since the PR is on a fork. Can you fix it (update the sc143 ref to use WCAG 2.2 instead of WCAG 2.1)?

giacomo-petri commented 4 months ago

@giacomo-petri I seem to be unable to solve the merge conflict myself since the PR is on a fork. Can you fix it (update the sc143 ref to use WCAG 2.2 instead of WCAG 2.1)?

Hi @Jym77, i don't see any WCAG 2.1 reference in the docs I have edited.

Jym77 commented 4 months ago

🤔 It looks like I did in fact manage to resolve the merge conflict…

Jym77 commented 4 months ago

Call for Review has ended, merging.

act-rules / act-rules.github.io