Open Jym77 opened 4 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
~(prettier changes should be fixed by #2173)~
@Jym77 would it be possible to split this PR into several smaller PRs? It would just help us to push some of the rules along without having to wait for us to review all of them.
@tombrunet Pinging you for SA
@Jym77 would it be possible to split this PR into several smaller PRs? It would just help us to push some of the rules along without having to wait for us to review all of them.
@tbostic32 I'm not sure it would make sense to review the atomic rules in isolation, plus there would be confusion around the shared definitions (they would either be duplicated in all PRs, with merge conflict nightmare upcoming, or be missing from some which makes them harder to read).
But I do agree the resulting PR is quite huge 😖
Is there anywhere we can view the built HTML for this branch? The diffs are so big they're hard to read, and since it's a new rule the whole thing needs reviewed as a whole.
Is there anywhere we can view the built HTML for this branch? The diffs are so big they're hard to read, and since it's a new rule the whole thing needs reviewed as a whole.
@dd8 -- We are working on setting up a Netlify site for https://act-rules.github.io We can have each PR built and deployed, which will hopefully improve things.
@tbostic32 I'm trying the "split" approach, by isolating one of the rules in #2182. That rule makes little sense in isolation, but hopefully will be easier to review and merge nonetheless.
We've also looked at getting PR-publish. It's a very good idea overall, but a bit tricky with our Github pages publish workflow (especially since it has been broken for a couple of years) See #2183 for some investigation.
Add rules for "Target Size (minimum)" and "Target Size (enhanced)" Success Criteria.
These are set up as composite rules in order to share the exceptions that are shareable.
"Target Size (minimum)" is messy due to the spacing condition that has to be failing in all Failed example, thus requiring quite a bit of scaffholding.
Closes issue(s):
Need for Call for Review: This will require a 2 weeks Call for Review (new rules 🎉)
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve