act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML
https://act-rules.github.io/
Other
131 stars 67 forks source link

HTML page has non-empty title [2779a5]: Shadow root example - Included as failed example 6 #2180

Open giacomo-petri opened 2 months ago

giacomo-petri commented 2 months ago

Closes issue(s): #2179

Description: Adding a failed example of an HTML page lacking a title but featuring a shadow root with a non-empty <title> that does not affect the page title into the HTML page has non-empty title [2779a5] rule.

Need for Call for Review: This will require a 1 week Call for Review


Pull Request Etiquette

When creating PR:

After creating PR:

When merging a PR:

How to Review And Approve

giacomo-petri commented 2 months ago

Hi @Jym77,

to be honest, it took me a while to figure out if Expectation 2 was supposed to clarify how to deal with shadow roots, but after reviewing the definitions, I think it's accurate. However, I do agree that it could be clearer and less time-consuming for users to understand how to handle shadow roots.

Jym77 commented 2 months ago

Hi @Jym77,

to be honest, it took me a while to figure out if Expectation 2 was supposed to clarify how to deal with shadow roots, but after reviewing the definitions, I think it's accurate. However, I do agree that it could be clearer and less time-consuming for users to understand how to handle shadow roots.

Yes, I think this is correct (this is also Alfa's interpretation). I think that this is a very old rule and we were not so conscious then about the differences between DOM and flat tree 😅 In any case, the example makes it clear that shadow DOM is ignored, so that's definitely going in the good direction.