search

actano / karma-cbt-launcher

Karma-Launcher for CrossBrowserTesting
1 stars 3 forks source link

Updated Karma Launcher #2

Open TimmyTango opened 6 years ago

TimmyTango commented 6 years ago

Hey Marc/Actano, Tim from CrossBrowserTesting. We've been getting a lot of requests for better Karma integration so I've been working off of your code and have a pretty good platform to continue development. We thought about sending a pull request, but as it's something we'd like to keep up to date, I was wondering if you would be willing to let us takeover the npm package. You can find the code I've been working on here: https://github.com/crossbrowsertesting/karma-cbt-launcher. It is basically your code without Babel/ES6 modules and creates the tunnel through our nodejs module vs the binary. I've tried to give proper attribution on all of the source files and on the readme, but let me know if I missed anything.

marcmenn commented 6 years ago

Hi Tim, thanks for your message. I'd be happy to handover the maintenance to you. Also, I'd really like to look over your code. Would you mind starting from a fork and PRing the changes? That would really help in looking into it and checking the compatibility. Thanks!

TimmyTango commented 6 years ago

Pull request is in. Implemented a new custom reporter to mark tests pass/fail through our api. Also added an example directory to show how to setup the configs.

marcmenn commented 6 years ago

Cool, thanks. I just took a look. I'll comment on your changes in the PR, ok? I totally agree and be happy, if karma-cbt-launcher belongs to and is maintained by you. I'll publish our version as is namespaced, until our stuff is running also with your changes.