actboy168 / YDWE

A Tool to Help the Creation of Warcraft III Map
GNU General Public License v3.0
462 stars 139 forks source link

Use stormlib compact when saving map #158

Closed Frotty closed 5 years ago

Frotty commented 5 years ago

Currently YDWE creates map mpqs with empty non addressed blocks. Run stormlib's compact to fix this.

actboy168 commented 5 years ago

Will this be a problem? As far as I know, the official map of war3 also has files that aren't in the listfile.

Frotty commented 5 years ago

Will this be a problem?

It has been a problem several times. YDWE outputs maps with different blocksize and fragmentation from the vanilla WE, thus the maps didn't work in wurst. We have worked around this, but it would be an easy fix on your side. Also these are gaps in the mpq, not real files.

This is the command I mean: http://www.zezula.net/en/mpq/stormlib/sfilecompactarchive.html For normal map sizes this process takes under a second for me and would ensure compatibility with other tools.

actboy168 commented 5 years ago

OK, I have added SFileCompactArchive.

Frotty commented 5 years ago

👍