actboy168 / lua-debug

Lua Debug Adapter for Visual Studio Code
MIT License
439 stars 95 forks source link

Debugging fails on ARM-based Chromebook aarm64 Linux #194

Closed olifink closed 2 years ago

olifink commented 2 years ago

it fails on a HP ARM-based Chromebook Linux with the following console output:

olifink@penguin:~/code/lua/hello$  /home/olifink/.vscode/extensions/actboy168.lua-debug-1.59.0-linux-arm64/runtime/linux-arm64/lua54/lua -e dofile\"/home/olifink/.vscode/extensions/actboy168.lua-debug-1.59.0-linux-arm64/script/launch.lua\"\;DBG\"11487\" /home/olifink/code/lua/hello/hello.lua 
/home/olifink/.vscode/extensions/actboy168.lua-debug-1.59.0-linux-arm64/runtime/linux-arm64/lua54/lua: (debugger.lua):47: unknown ARCH
stack traceback:
        [C]: in function 'assert'
        (debugger.lua):47: in local 'detect_linux'
        (debugger.lua):72: in upvalue 'detectLuaDebugPath'
        (debugger.lua):116: in upvalue 'initDebugger'
        (debugger.lua):146: in method 'start'
        ...actboy168.lua-debug-1.59.0-linux-arm64/script/launch.lua:29: in upvalue 'f'
        (debugger.lua):197: in global 'DBG'
        (command line):1: in main chunk
        [C]: in ?

system reports the aarch64:

$ uname -a
Linux penguin 5.10.120-16471-g167ad2e5dcba #1 SMP PREEMPT Fri Jul 29 18:58:01 PDT 2022 aarch64 GNU/Linux

it does actually work fine if debugger.lua is updated to something like:

        local function detect_linux()
            if shell "uname -m" == "aarch64" then
                PLATFORM = "linux-arm64"
            else
                PLATFORM = "linux-x64"
            end
        end
actboy168 commented 2 years ago

You can write a pull request.

olifink commented 2 years ago

ok, created PR for it. I didn't add more testing logic for other architectures/platforms.