actboy168 / lua-debug

Lua Debug Adapter for Visual Studio Code
MIT License
439 stars 95 forks source link

Debugger doesn't seem to start with 2.0.10, but works with 2.0.9 #298

Open fstenstrom opened 3 months ago

fstenstrom commented 3 months ago

The debugger doesn't seem to start with 2.0.10, but it works with 2.0.9.

For 2.0.10, nothing happens when starting a debug session. VS Code just shows that "something is loading" for about a second, and then nothing more. I didn't manage to find any logs.

I'm using WSL with Devcontainer and Lua 5.4. Attached zip with setup: proj.zip

dev0x13 commented 3 months ago

I confirm, that happens on my setup as well (VSCode 1.92.0, Ubuntu 24.04, Lua 5.4).

fikin commented 2 months ago

and i can confirm same (debian bookworm, vscode 1.91.1, lua53)

yuanyan3060 commented 2 months ago

and i can confirm same (arch, vscode 1.92.2, luajit)

musteresel commented 1 month ago

Can confirm with VSCode:

Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Linux x64 5.15.0-117-generic

I'm using a Docker devcontainer if that makes any difference. Also had the same issue with VSCode 1.85.1

Downgrading to 2.0.9 solves the issue

musteresel commented 1 month ago

https://github.com/actboy168/lua-debug/compare/9e1f465..4412c81#diff-3cf49c5cb77b73d73f43a5a0fa4da72179071c9100c3044ef2a3a84bc3a5b58aR105

This snippet from the comparison between 2.0.9 and 2.0.10 looks strange to me. Commit is here https://github.com/actboy168/lua-debug/commit/2a353aa1ee09bbcf55497af99352ea9d1b420341 but doesn't give much information which bug and why?

Original code filtered events to EPOLLIN or EPOLLOUT when event EPOLLERR or EPOLLHUP comes. New code just adds those events (both; even if they're not there) -- no idea why, but this could be legit: https://stackoverflow.com/a/29206631/1116364

district10 commented 1 month ago

2.0.9 does not work for me either.

musteresel commented 2 weeks ago

@actboy168 Is this commit a6a380ec2cd9b367464bd65b1aa6a1a4f134ca90 referring to this bug here?