actboy168 / vscode-tasks

MIT License
37 stars 14 forks source link

add a function and fix some errors #10

Closed alexzshl closed 5 years ago

alexzshl commented 5 years ago
  1. add function: rename the name on task show on statusbar by edit task.json
  2. fix error: when the arg's type is object,task hide don't work
actboy168 commented 5 years ago

It looks good to me. But split the bug fix and add features into two pull requests.

alexzshl commented 5 years ago

好的.但是我升级到1.37之后,所有的任务向左偏移了,超过了错误图标和警告图标,是否可以修复呢?


From:alex email:zd870905@126.com

On 8/20/2019 10:17,actboy168notifications@github.com wrote:

@actboy168 requested changes on this pull request.

In js/extension.js:

     }

}

 let version = vscode.version.split(".");

This is to fix the 1.36-specific bug, please don't change it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

actboy168 commented 5 years ago

这个和1.35以及之前的表现是一致的

actboy168 commented 5 years ago

statusbar的优先级,不能称之为异常,这是一直以来的行为。我会考虑更好的方案,但不能在这个PR里修改。