actboy168 / vscode-tasks

MIT License
37 stars 14 forks source link

Extension settings not available #22

Closed rccoleman closed 4 years ago

rccoleman commented 4 years ago

At some point recently the extension settings for this extension seem to have disappeared and are no longer viewable or modifiable. I see the same behavior on code-server and on a native MacOS installation - I can see the settings that the extension intends to make available in the "Feature Contributions" section in the addon page, but clicking the cog on the extension and selecting "Extension Settings" brings up nothing (search is actually "@ext:actboy168.tasks". Same result if I go into Settings and manually search for "tasks". Other extensions chosen at random, such as this properly expose their settings.

rccoleman commented 4 years ago

Looks like adding the following to the configuration definition fixes it:

            "title": "vscode-tasks",

PR submitted: https://github.com/actboy168/vscode-tasks/pull/23

actboy168 commented 4 years ago

I cannot reproduce it. Adding a title is also good, but I want it to be Tasks instead of vscode-tasks.

rccoleman commented 4 years ago

Weird. I wonder if it was some left over cruft from an older installation, but it was happening on both my MacOS install and with a vscode-server as part of my Home Assistant installation. When I uninstall the extension, restart VSCode, and re-install from the Marketplace, the settings are coming up now. So somehow adding the title and reloading from a local .vsix seems to have fixed it, but building and loading .vsix files of earlier versions first didn't fix it. I do see that after loading the latest version from the Marketplace it's still using the "vscode-tasks" heading that I added, even though it's missing from the released version:

Screen Shot 2020-08-09 at 6 53 26 PM
rccoleman commented 4 years ago

It looks like just uninstalling and reinstalling the extension doesn't remove the directory or configuration from the .vscode/extensions directory. If I uninstall the extension, delete that directory, and reinstall 0.6.0 from the Marketplace, I again get "No Settings Found" when hitting the cog and selecting "Extension Settings":

Screen Shot 2020-08-09 at 9 35 12 PM

vs. when it works:

Screen Shot 2020-08-09 at 9 38 15 PM
actboy168 commented 4 years ago

It may be a bug in VSCode.

rccoleman commented 4 years ago

Could be. It used to work, and I only noticed the issue when I started seeing missing tasks in the status bar and I couldn't access the settings to increase the limit from 6.

rccoleman commented 4 years ago

Filed an issue against the main project: https://github.com/microsoft/vscode/issues/104442

rccoleman commented 4 years ago

Looks like it's being fixed via https://github.com/microsoft/vscode/commit/67243326c1aabab30c7500e1fb4fd5a19e385e13. I'll close this issue now.