Open alexzshl opened 1 year ago
I prefer simple implementations like #32.
As I said in #28, adding a running status label will cause the position of the statubar to change. So it should also have a stop state label.
I prefer simple implementations like #32.
As I said in #28, adding a running status label will cause the position of the statubar to change. So it should also have a stop state label.
Yes, #32 is indeed more concise because I didn't know before today that the task has an ID, so I had to calculate the jsonstring of the entire task object. If the change in location is indeed a problem, refer to the submission and I think there are some solutions:
Everything is done to ensure that the position of the button text remains unchanged. Although the effect may not be satisfactory to everyone, controlling whether this feature is effective through configuration will at least not affect the original functionality
I have implemented it in https://github.com/actboy168/vscode-tasks/commit/7ef7e1bab90e65a2bb82e9b6f9bb5be67098977b
For #27 and some suggests from vs extension market.
Considering that some users want the status bar button to have a special display when running tasks to indicate that the corresponding task is running, I have attempted to add this feature. About two years ago, I had a similar plan, but due to some of your concerns, I gave up. Now I have re examined the feasibility of this feature and reviewed the official documentation. I am not sure if this will affect other features of the plugin. I hope you can provide your feedback. Since my last merge request, you have refactored most of the code, and there are some parts that I cannot fully understand. Therefore, I cannot be 100% certain that the code for this price increase will adapt to all scenarios. If possible, perhaps improvements can be made in subsequent work.
About this pull request:
effect:![image](https://github.com/actboy168/vscode-tasks/assets/39125296/1dbe96bf-cbad-4bb6-8b75-bafa471242ad)