search

actboy168 / vscode-tasks

MIT License
37 stars 14 forks source link

Taskbar ordering conflicts with git #8

Closed MarkusRodler closed 5 years ago

MarkusRodler commented 5 years ago

Some days ago I noticed that the ordering of tasks in the taskbar is wrong: image

The git branch and refresh button should be the first entries. Can you modify the position? It seems the position of the git entries depends on the time the Tasks plugin needs to load

actboy168 commented 5 years ago

This is a VSCode bug that has been fixed in 1.37 and may be fixed in 1.36.1.

MarkusRodler commented 5 years ago

Thanks for the information. Keep up the great work!

fheinicke commented 5 years ago

I just updated to VS Code 1.36.1 where this issue is supposedly fixed (see issue microsoft/vscode#76561) by the PR microsoft/vscode#76598. However the issue is still coming up for me when using this extension.

grafik

actboy168 commented 5 years ago

I think this is two bugs.

infinnie commented 5 years ago

https://github.com/actboy168/vscode-tasks/blob/master/js/extension.js#L115 如果本扩展的状态栏项 priority 为 50 的话那和 Problems 的相应 priority 是一样的，但是根据此修复 https://github.com/microsoft/vscode/pull/76598/files#diff-c8a07f370ae15468fbaf8367a502ced0R128 似乎该修复之前的问题之一在于 Tasks 和 Problems 具有相同的优先级—50 (https://github.com/microsoft/vscode/pull/76598#issuecomment-508482343) 优先级 10000, 50 & 49 看来都已经被内置状态栏项使用了。你可能有必要防止与他们的冲突。

fheinicke commented 5 years ago

The issue seems to have been fixed by VS Code 1.37.0 or 1.37.1 like @actboy168 noted - I cannot reproduce it anymore. @MarkusRodler can you confirm?

MarkusRodler commented 5 years ago

Yes I can confirm that it is fixed now aufter the update.