acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Route snapper behaviour around footpaths and elevated footpaths #176

Open Sparrow0hawk opened 1 year ago

Sparrow0hawk commented 1 year ago

Observed a user doing this during testing session. It wasn't super clear to the user why this happened but on actually looking at the map it makes sense (two footpaths cross one over the other).

Steps to reproduce

  1. Navigate to https://acteng.github.io/atip/scheme.html?authority=York#17.76/53.95755/-1.09187
  2. Try and draw a footpath route from the footpath crossing station road walk up the city wall footpath in a northerly direction

Behaviour

You get the behaviour shown because the footpath on the walls is elevated and not directly reachable on the route sketched. What we've got here is the correct behaviour I believe but it wasn't clear to a user.

https://github.com/acteng/atip/assets/20887250/8b5999e7-4da5-4d82-b74d-f1e94430ffea

dabreegster commented 1 year ago

The video didn't upload (sometimes GH flakes on this); could you retry please? I got something like this, but not sure if that's the problem you mean: Screenshot from 2023-05-18 10-27-18

Sparrow0hawk commented 1 year ago

Yeah i'm retrying to little avail but what you've got there is exactly what i'm describing.

dabreegster commented 1 year ago

https://www.openstreetmap.org/way/360545734#map=19/53.95714/-1.09164 The footpath goes under City Walls here, according to OSM. We route based on the graph connectivity, not on a planar graph. We could possibly detect when a route interacts with bridges/tunnels like this. But what should we do to explain?

dabreegster commented 1 year ago

Google Maps for reference: https://www.google.com/maps/dir/53.958492,-1.0905469/Cycle+Heaven,+Station+Rd,+York+YO24+1AY/@53.9572584,-1.0921919,17.17z/data=!4m10!4m9!1m0!1m5!1m1!1s0x487930550d04e92b:0x99cd6d1701efff0a!2m2!1d-1.0925836!2d53.9576762!3e2!5i1 Screenshot from 2023-05-18 10-31-15

Sparrow0hawk commented 1 year ago

But what should we do to explain?

I am not entirely sure at this stage, something to have a think on