search

acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

State changing bugs: disable things when editing 142 #230

Closed Pete-Y-CS closed 1 year ago

Pete-Y-CS commented 1 year ago

…files and clearing all

This is a new version of: https://github.com/acteng/atip/pull/196

The old work for that, for now, is kept at the branch: state-changing-bugs-142-legacy so I can refer to it if there's stuff I want to reuse.

Pete-Y-CS commented 1 year ago

Tests passing, I'm removing this from WIP!

dabreegster commented 1 year ago

Bump -- any reason to not merge this?

Pete-Y-CS commented 1 year ago

Not to my knowledge

robinlovelace-ate commented 1 year ago

Final code janitor type job if you get a chance @Pete-Y-CS: Delete the merged branch :shower:

Pete-Y-CS commented 1 year ago

I suppose we can set repo-level defaults for this kinda stuff? (Preferring rebase and deleting branch)

robinlovelace-ate commented 1 year ago

Yeah good point and links to @Sparrow0hawk's ideas about repo defaults. I was looking at bots like 'bors' and all sorts but seems it's just a per repo setting: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches

robinlovelace-ate commented 1 year ago

Can we configure all acteng repos to do that? Will save many clicks if so!

Sparrow0hawk commented 1 year ago

I've enabled it on this repo and will look at configuring across all acteng repos