acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Don't lose geometry edits when changing modes #253

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

See #247 for context. This PR does a few things:

These changes are for polygons and linestrings, but not points. The point tool is trivial; the user just has to click the map to place or move something. If they go click another button somewhere, there's no reasonable "last edited state" to save.

Manual testing seems rock solid, but I'm working on new Playwright tests now.

dabreegster commented 1 year ago

Adding Robin as a reviewer for UX / "is this nicer?" check: https://acteng.github.io/atip/autosave/scheme.html?authority=Adur

robinlovelace-ate commented 1 year ago

Adding Robin as a reviewer for UX / "is this nicer?" check: https://acteng.github.io/atip/autosave/scheme.html?authority=Adur

Will try now...

robinlovelace-ate commented 1 year ago

Tested and seems to work great to me. Great work and many thanks for detailed comments on the code, will help onboard others to the codebase and make code review easier (although I'm not in a position to review the code)!