search

acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Get govuk installed, following #267

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

https://frontend.design-system.service.gov.uk/get-started. Very lightly change the browse scheme page typography using Sass, to preview the next steps for integration.

This is an alternative to #258. Because switching is going to take a few steps, I propose we do it gradually. The build setup is subtle enough to deserve its own step. After this PR, I propose we update the two simple pages (scheme browsing and choosing an area) to completely use govuk styles, figuring out some of the patterns for using Sass vs Svelte components. Then tackle the much more complex main page.

Preview: https://acteng.github.io/atip/govuk_frontend_v2/browse.html The text style changes slightly: Screenshot from 2023-07-11 18-46-56 I have also temporarily copied in https://design-system.service.gov.uk/components/accordion to test the JS integration e2e.

Great thanks for help in https://github.com/alphagov/govuk-frontend/issues/3940 figuring out how to use Sass to keep our code simple!

dabreegster commented 1 year ago

I copied in the accordion HTML temporarily to verify JS working:

https://github.com/acteng/atip/assets/1664407/e1f1c8ae-c555-4bd0-8b29-4a76a94268e0

robinlovelace-ate commented 1 year ago

I copied in the accordion HTML temporarily to verify JS working:

screencast.mp4

This looks great!

Worth posting in the ATIP channel and tagging people who were asking for it?

dabreegster commented 1 year ago

Worth posting in the ATIP channel and tagging people who were asking for it?

I'd vote we wait until the govuk integration is farther along. There's nothing notable to show yet, but the scheme browse page is a next step.