Consolidate 3 layer-like controls

acteng / atip

Active Travel Infrastructure Platform

https://acteng.github.io/atip/

Apache License 2.0

22 stars 4 forks source link

Consolidate 3 layer-like controls #277

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

Layer controls are often a map overlay, like in https://www.planning.data.gov.uk/map. We use that today for switching basemaps and showing a legend, but the speed limit layer is smushed into the sidebar for no good reason. Group everything and make the entire overlay hideable.

https://github.com/acteng/atip/assets/1664407/12fe6689-530e-4c73-ad09-7f575a24dfa7

Pete-Y-CS commented 1 year ago

I wonder if the name layers isn't quite right? Maybe it should be called map controls?

It might also be nice to have something telling you that the legend is a legend, just a teeny header

dabreegster commented 1 year ago

It might also be nice to have something telling you that the legend is a legend, just a teeny header

Do you think the legend itself should be hideable separately using its own details? Or two layers of that component are overkill/confusing?

robinlovelace-ate commented 1 year ago

Just saw this. Definite improvement I think, and makes important speed data more visible. Layers sounds find to me, maybe "Map layers" as opposed to data layers would be better?

dabreegster commented 1 year ago

Moving to draft, I'll pick this up after #282

dabreegster commented 1 year ago

Please take another look; this PR now does two things:

remove the legend from the browse page entirely; it's unhelpful there currently, and we're going to change to let people control the coloring by different variables
On the editing page, group layer controls together. I decided to hide controls by default to make the UI simpler, and de-emphasize the 4-color legend.

https://github.com/acteng/atip/assets/1664407/d2bae816-f100-4f8d-a0c4-f3bbbae8190a

dabreegster commented 1 year ago

Demo at https://acteng.github.io/atip/combine_layer_controls/scheme.html?authority=West of England Combined Authority

robinlovelace-ate commented 1 year ago

Finally taking a look...

robinlovelace-ate commented 1 year ago

Instant 👍 to integrated legend. This is a minor but IMO important change to the UI with UX benefits so definitely worth merging to keep momentum going. Thanks Dustin for the work and patience!