acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Mechanical refactor to group imports from common and govuk directories #281

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

Makes using these common libraries less verbose. https://javascript.info/import-export#re-export talks about this approach.

dabreegster commented 1 year ago

We will definitely want to share these! This is a step towards that at least; we could publish an NPM packge and then just swap "../govuk" with "govuk-svelte". Not exactly sure how to name that package yet... I wouldn't want to suggest to anyone external to ATE that it's ready to use. https://github.com/PaulioRandall/svelte-gds-design-system is the one related library I've found, also to consider using / taking inspiration from

dabreegster commented 1 year ago

And if we want to punt on publishing to NPM, we can temporarily depend on code from here in another repo by using the GH link: https://github.com/dabreegster/osm2svelte/blob/8bad22ad7707a8dcfc79b3416acf8ef8c15c1b75/package.json#L30 But this really is a temporary hack