search

acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Some usability improvements for browse page #290

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

First off, our free-form text filter is confusing before this PR. If you search for "school", you see things on the map that just happen to be in the same scheme that mentions schools. This PR changes it so that you only see interventions mentioning that word. And to make that clear, highlight the search result in the popup.

Second, I flipped the optional layers to be disabled by default. We can revisit this as we have more of them and understand how they're used, but at the moment, I think they're a distraction when loading scheme data.

Third, the "edit on map" button is disabled when the authority name is incorrect, so people don't even click and later get an error. I'd very much like to fix the root cause here and rebuild the all-scheme dataset from its original input, but this is a stop-gap.

https://github.com/acteng/atip/assets/1664407/2d117def-87f4-49f2-8706-80646c9a1912

dabreegster commented 1 year ago

Adding Robin for async feedback on the search changes, but going to merge now and handle any feedback later. Thanks :)