search

acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Add an MRN layer and adjust layer help #291

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

Add a layer for the Major Road Network, generated in https://github.com/acteng/atip-data-prep/pull/14.

Also switch from tooltips on the checkboxes to a full help modal. That lets us include external links, full attribution, and -- for some of the next layers -- give more details about assumptions / limitations of the data.

https://github.com/acteng/atip/assets/1664407/9e6a6cc3-5381-4188-a5f6-109ba55862bf

robinlovelace-ate commented 1 year ago

Based on the vid, the lines are really wide, can they pls be thinner? Other than that big 👍

dabreegster commented 1 year ago

Thanks for the quick look! I thinned a bit: Screenshot from 2023-07-25 14-48-35

All of the styling options are still TBD; I'm picking kind of arbitrary colors right now. Also not sure how things should work when the layer overlaps scheme data.

One of the Playwright tests just failed on GH -- "the viewport changes only once when opening a form". This PR doesn't change any behavior there. I re-ran the test locally and manually tried the behavior, and everything's fine, so going to treat it as a (not-yet-seen) flake. Will see if the re-run in GH hits it again, but probably not worry about it.