acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Update route-snapper #376

Closed dabreegster closed 10 months ago

dabreegster commented 10 months ago

Brings in changes from https://github.com/dabreegster/route_snapper/blob/main/CHANGES.md#022.

https://github.com/acteng/atip/assets/1664407/490bed16-37e8-42d4-ae16-1546897fbaa4

Demo at https://acteng.github.io/atip/route_snapper_update/scheme.html?authority=LAD_Adur.

dabreegster commented 10 months ago

Pete, could you try using this for that example case and see if it feels better?

robinlovelace-ate commented 10 months ago

Minor aesthetic niggle, really not a fan of this empty space that is too big not to be noticed but too small to be useful:

image

robinlovelace-ate commented 10 months ago

Either full banner (that's foldable?) or keep in a left or right panel would be neater, like (hate to admit it's good) Google Maps : )

robinlovelace-ate commented 10 months ago

Probably not foldable as it has one job.

robinlovelace-ate commented 10 months ago

In terms of extra space on right: love it! Minor tweak can overcome my niggle above, make it full width is first thought.

dabreegster commented 10 months ago

Thanks for the feedback! Specifically can you create a new route and make something that involves both snapping and freehand points? That's the big change here, but will also incorporate the top bar design

Pete-Y-CS commented 10 months ago

Code looks good. Gonna chat over a couple of behavioural niggles when you've got a moment but no comments on the code itself

dabreegster commented 10 months ago

PTAL, demo is now at https://acteng.github.io/atip/route_snapper_update/scheme.html?authority=LAD_Adur.

When the black dots are dense on a red line, it's maybe a bit hard to see. It looked worse to me to put the line on top. Styling suggestions welcome!

Pete-Y-CS commented 10 months ago

Changes look great!