acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Revert superscheme #387

Closed dabreegster closed 10 months ago

dabreegster commented 10 months ago

There's a critical problem with the superscheme PR: edits to the per-scheme pipeline form aren't preserved across page refresh. For the workshop tomorrow, it's more important to start collecting that form than to try showing multiple schemes at the same time.

A few problems that looked like they were introduced in the merge/rebase:

I think my biggest confusion is why this new feature is specialized for the pipeline schema. In my mind, this should be tackling #152 -- a way to edit multiple files/layers/schemes for the same authority boundary in the sketch tool at the same time. It has nothing particular to do with the attributes we're collecting in the pipeline schema. We should think through https://github.com/acteng/atip/pull/379#issuecomment-1784928203 and settle what the GJ data looks like, how the UI should look, and then the implementation can follow from that.

My vote for the GJ representation is to support only two types of files: a single scheme and a combined scheme. We have both today (the second in the browse tool), and we can adjust them to better include the new pipeline fields

robinlovelace-ate commented 10 months ago

Important fix ready for workshop by the looks.

dabreegster commented 10 months ago

I'll merge to simplify all the rebasing for the pipeline branch. I'm also going to take a step back in the workshop tomorrow and ask: