search

acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Loading a new all_schemes_data.geojson on browse page doesn't reset filters #417

Open Pete-Y-CS opened 9 months ago

Pete-Y-CS commented 9 months ago

So if you upload a file with a certain set of funding sources, then, a new file with a different set of funding sources, you the schemes being displayed will change to the new file, but the filter options will not update

dabreegster commented 9 months ago

If you're looking into bugs here, another (maybe related, maybe not) one is the filter text broke at some point. It filters the map correctly, but if you hover and get a tooltip, the highlighting went away.

Relatedly, it'd be nice to start some tests for the browse page. Bit hard to capture some of these interactions, but could be worth it as regression tests

Pete-Y-CS commented 9 months ago

👍🏻 just logging stuff that has come up in getting the atf4e data (which you can see the code for here: https://github.com/acteng/atip-scheme-data/pull/3 [still need to update the Readme since I'm introducing code to the repo])

also I've uploaded the data to the sharepoint so you can see that in practice if you're interested