acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Don't forget about scheme name #456

Closed dabreegster closed 7 months ago

dabreegster commented 7 months ago

A few requested changes:

Before merging, I want to see if scheme name is ever blank, because then the SchemeCard title will be hard to click. We could fallback to the reference? Or maybe this never happens; we can assert in aatip-scheme-data and update the TS if so.

Demo: https://acteng.github.io/atip/browse_show_diff_stuff/browse.html

dabreegster commented 7 months ago

jq '.schemes[] | .scheme_name' all_schemes_output.geojson shows we have scheme name for everything, actually! So I'll merge this now so because can start using it, and follow up by updating the TS definitions and asserting this remains true in atip-scheme-data