acteng / atip

Active Travel Infrastructure Platform
https://acteng.github.io/atip/
Apache License 2.0
22 stars 4 forks source link

Fix disapparing images when switching basemaps #486

Closed dabreegster closed 4 months ago

dabreegster commented 4 months ago

Two commits here. The first is just refactor, trying to be more precise about the combinatorial explosion of basemap and overlay layers we have. And the second fixes the problem reported recently. Enable cycle parking (which uses an extra image we load), switch basemaps -- now the symbol still works. We just needed https://github.com/dimfeld/svelte-maplibre/blob/master/CHANGELOG.md#082.

Note I still think there might be some z-order oddness when changing basemaps. We decide the layer order when the layers are first created, which'll depend on the basemap layer names that exist at that point. If the user switches basemaps, I don't think we run this calculation again. Harder one to think about for the future.