actifyjs / actify

🌻React Material Design 3 Components Library
https://actifyjs.com/
MIT License
119 stars 17 forks source link

Fix docs and typescript types #27

Open HironTez opened 1 week ago

HironTez commented 1 week ago

Describe the bug

The docs are often misleading. For example, it says there is a "disabled" property in the TextField component when it's actually "isDisabled".

Also, I would never know that you should use "onPress" instead of "onClick" if I hadn't seen react-aria's warning in the browser console. The onClick doesn't work on mobile.

And there's a plenty of properties missing in the docs, like Checkbox "variant".

Some properties are missing in types, e.g. "label" in TextField. Types of some components just don't work, for example types of Checkbox and Button

Desktop.

Smartphone.

I like this library overall and look forward to seeing improvements

HironTez commented 1 week ago

Upd: it's very strange but all the types have been fixed once i installed "@react-spectrum/toast"

HironTez commented 1 week ago

I've checked it multiple times and types don't work correctry without react-spectrum. As a temporary fix i've added it to the devDependencies in my package.json.

lerte commented 1 week ago

You are right, I am currently refactoring my components to use react-aria. So the documentation is not up to date. Thanks for your feedback.