search

actigraph / agcounts

Code for the technical report on the ActiLife counts algorithm.
GNU General Public License v3.0
32 stars 13 forks source link

Separate functions in _extract #2

Closed muschellij2 closed 2 years ago

muschellij2 commented 2 years ago

Here is refactored some of the _extract functions for more modular code, added a verbose argument to see diagnostic printing, and tried to do some memory tidying. I'm not the best at Python (more R), but this should still pass the checks. This helps with really large data (7 days at 80Hz) that I needed individual functions for garbage collection.

Also, I think it's worthwhile to potentially allow users to run each axis separately for memory saving (as filtering and and all functions do not borrow info across axes), but may not be required.

rouzbeh commented 2 years ago

Here is refactored some of the _extract functions for more modular code, added a verbose argument to see diagnostic printing, and tried to do some memory tidying. I'm not the best at Python (more R), but this should still pass the checks. This helps with really large data (7 days at 80Hz) that I needed individual functions for garbage collection.

Also, I think it's worthwhile to potentially allow users to run each axis separately for memory saving (as filtering and and all functions do not borrow info across axes), but may not be required.

Sure, that is something I can add.