search

actility / device-catalog

This repository contain all device profiles and public drivers.
22 stars 30 forks source link

Apply watteco th v4 suggested changes #61

Closed mostafaibr closed 1 year ago

Logia556 commented 1 year ago

When i talked with Bruno Regnier, he told me to put the three js file you put in decoder above any device as it will be the same for all of them. I suppose that it is not possible as it would make the captors driver incomplete technically, but it implise that there will be duplicata of the same files several times. if this is not a problem for you, and you think this commit is functionnal, I suppose you could commit it. However this version and my actual version of the common files is already different, and are supposedly subjects to further revisions. Also the 64Ko limit impose me to have a different version of the webpack.config.json that allow me to compact it while still working with jest ; it is not the version in the merge request #57 I made but almost the same.

mostafaibr commented 1 year ago

Hello @Logia556 ,

No problem, if that is the case, I will re add the files under /drivers and then you can use them for several drivers to avoid redundancy.

Thank you.