search

actimeo / ng2-i18next

use i18next with Angular2
MIT License
11 stars 9 forks source link

Consider using a different name for the `alert$` property #3

Closed mazswojejzony closed 8 years ago

mazswojejzony commented 8 years ago

Disclaimer first: feel free to reject/close this issue as this is more of a style/taste preference. ;-)

Wouldn't the this.i18n.alerts$.subscribe read better as this.i18n.whenReady.subscribe or maybe this.i18n.whenInitiazlied.subscribe?

alert$ seems strange to me. But again, maybe it is just me. :-)

actimeo commented 8 years ago

As a matter of fact, it's a misnamed variable. I'll change it.

mazswojejzony commented 8 years ago

Thanks a lot! :-)