Checking pixellimit for r.import commands

actinia-org / actinia-core

Actinia Core is an open source REST API for scalable, distributed, high performance processing of geographical data that uses mainly GRASS GIS for computational tasks (DOI: https://doi.org/10.5281/zenodo.5879231) | Tutorial: https://actinia-org.github.io/actinia-core/ | Docker: https://hub.docker.com/r/mundialis/actinia-core

https://actinia.mundialis.de/

GNU General Public License v3.0

78 stars 22 forks source link

Checking pixellimit for r.import commands #491

Closed linakrisztian closed 7 months ago

linakrisztian commented 8 months ago

Check the current r.import command against the user cell limit (within ephemeral_processing.py) + added tests for this check

PR additionally contains small linting changes:

test_download_cache.py (line too long)
format markdown

neteler commented 8 months ago

May I suggest adding a test test_download_commands_vsicurl similar to

https://github.com/actinia-org/actinia-core/blob/852f159696b93848e8a7c79f3bbcecb667e02b09/tests/test_geodata_import.py#L170

The test may then execute two imports:

r.import on /vsicurl/https://data.mundialis.de/geodata/lulc-germany/classification_2021/classification_map_germany_2021_v01_COG.tif --> should fail as too many pixels
r.import on /vsicurl/https://github.com/OSGeo/grass/raw/main/raster/r.in.gdal/testsuite/data/elevation.tif --> should succeed as only 150x135 pixels

linakrisztian commented 8 months ago

@neteler Good hint, I will add a test and thanks for the example data. I had a look and I think it is not reasonable to put it into actinia-core/tests/test_geodata_import.py. Within this test the download and import for vector and raster data is tested. I will create some separate test-file test_raster_import_pixellimit.py, checking the pixellimit for all r.import commands.