Update organization name and fix bitnami repo link

actinia-org / helm-charts

actinia helm-charts

Apache License 2.0

2 stars 3 forks source link

Update organization name and fix bitnami repo link #54

Closed LukasLohoff closed 1 year ago

LukasLohoff commented 1 year ago

updates README and charts for the new organization name, especially the gh-pages links (i.e. https://mundialis.github.io/helm-charts/) were not working anymore
uses a legacy bitnami repo because the current one does not support versions older than v16 (see #53)
in the future the redis version should probably be updated, the newest version is 17.9.5
- this seems to be a bigger change, as this are multiple major versions. Link to the upgrade notes: https://github.com/bitnami/charts/tree/main/bitnami/redis#to-1300

@metzm @mmacata Please review

Should I update the chart versions?

mmacata commented 1 year ago

Should I update the chart versions?

Do you mean for the redis chart? To me it looks like there is no real breaking change, so if you are able to test the update (even after merge would be fine - if it breaks, we remove the broken version and go back) then yes please :)

LukasLohoff commented 1 year ago

Thanks for the review!

Do you mean for the redis chart? To me it looks like there is no real breaking change, so if you are able to test the update (even after merge would be fine - if it breaks, we remove the broken version and go back) then yes please :)

I meant updating the actinia chart version itself, since the repo and some metadata changed (e.g a patch version update).

For the redis chart there definitely are breaking changes, the link I provided was for version 12 -> 13, but we also need to consider the other major updates up to version 17. Thats probably something for another day

LukasLohoff commented 1 year ago

Ok, most changes only affected settings which are not used here. Tried to update to 17.9.5 in 29f4e2871d526a4883c7a44f5daae331f5bc2290 And I also updated the chart versions

Let's see :pray:

LukasLohoff commented 1 year ago

I think the new redis helm chart version also requires a newer k8s version (>= 1.19)

mmacata commented 1 year ago

@jorzekowsky can you have a look at this please? Do we need successful tests for v1.12.10 - v1.14.10? Or would it be better to update the tests ittself?