search

action-is-hope / shelley

Unstyled React component library using stylable and react-aria.
5 stars 2 forks source link

Beacon 2600 speed dial #139

Closed Vaiginta closed 12 months ago

2creative commented 1 year ago

Hi, there is no documentation :) Please have a look at other components for examples. How it works, how it is implemented, source code etc.

2creative commented 1 year ago

Some of the individual components may do with some "data-id" for testing purposes.

Also some tests would be nice :)

2creative commented 1 year ago

Correct me if I am wrong but I think we can combine the SpeedDial-related components in one folder? SpeedDial and SpeedDialAction for example.

Vaiginta commented 1 year ago

Correct me if I am wrong but I think we can combine the SpeedDial-related components in one folder? SpeedDial and SpeedDialAction for example.

I couldn't see another example of similar component in one folder. For example Radio and RadioGroup are in separate folders. @mnapthine what do you think?

mnapthine commented 1 year ago

Correct me if I am wrong but I think we can combine the SpeedDial-related components in one folder? SpeedDial and SpeedDialAction for example.

I couldn't see another example of similar component in one folder. For example Radio and RadioGroup are in separate folders. @mnapthine what do you think?

Yeah, I did ant to move stuff around for some... Tabs and TableView are both examples of multiple in one folder.

mnapthine commented 1 year ago

Couple of things to consider:

If we want it quickly to use with the editor then maybe we should just put this in the other repo or we could use a Menu for the moment, it won't look the same but it would be functionally more like it. The editor has keyboard accessibility issues as well but in the CMS repo we can potentially look at resolving issues later on.