actionhero / actionhero

Actionhero is a realtime multi-transport nodejs API Server with integrated cluster capabilities and delayed tasks
https://www.actionherojs.com
Apache License 2.0
2.4k stars 259 forks source link

An in-range update of ws is breaking the build 🚨 #1422

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency ws was updated from 7.2.2 to 7.2.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ws is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - βœ… **ci/circleci: build:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/actionhero/actionhero/5716?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: linter:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/actionhero/actionhero/5717?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: test-node-v8:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/actionhero/actionhero/5718?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: test-node-v10:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/actionhero/actionhero/5720?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: test-node-v13:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/actionhero/actionhero/5719?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: test-node-v12:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/actionhero/actionhero/5721?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).

Release Notes for 7.2.3

Bug fixes

  • WebSocket#{p{i,o}ng,close}() now thow an error if the data to send is too
    large to fit in a control frame (e54f08d).
Commits

The new version differs by 2 commits.

  • 5fcdc42 [dist] 7.2.3
  • e54f08d [fix] Make WebSocket#{p{i,o}ng,close}() check the data size

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 7.2.2 your tests are passing again. Downgrade this dependency πŸ“Œ.