search

actionless / pikaur

AUR helper with minimal dependencies. Review PKGBUILDs all in once, next build them all without user interaction.
GNU General Public License v3.0
866 stars 87 forks source link

Ignored AUR packages are passed to pacman sysupgrade as `pacman -Su --ignore ignored_aur_pkg` #527

Open ckotte opened 3 years ago

ckotte commented 3 years ago 
Pikaur v1.6.12
Pacman v5.2.2 - libalpm v12.0.2
Description:

Why are --needed and --ignore, for every git package, are added to the sysupgrade pacman command?

Can those options be removed? The AUR packages are not updated during the fist pacman run anyway or do I miss something? I could also execute sudo pacman -Syu and then pikaur -Sua --devel --needed --ignore gnome-shell-extension-caffeine-git with the same result; just without --needed and --ignore.

This is not really a problem. I just cannot see the full command in the snapshot description; Also if I increase the description length to more than 100 characters. It would help options could be removed when they are not needed.

Log:
pikaur -Syu --devel --needed --ignore gnome-shell-extension-caffeine-git
...
looking for conflicting AUR packages...
:: Downloading the latest sources for a devel package numix-circle-icon-theme-git...
:: Downloading the latest sources for a devel package macchiato-git...
:: Downloading the latest sources for a devel package plotinus-git...
:: Downloading the latest sources for a devel package gnome-shell-extension-shelltile-git...
:: Downloading the latest sources for a devel package gnome-shell-extension-sound-output-device-chooser-git...
:: Downloading the latest sources for a devel package rhythmbox-plugin-alternative-toolbar-git...
:: Downloading the latest sources for a devel package materia-theme-git...
:: Downloading the latest sources for a devel package wat-git...
:: Downloading the latest sources for a devel package gnome-shell-extension-gtile-git...
:: Downloading the latest sources for a devel package numix-circle-arc-icons-git...
:: Downloading the latest sources for a devel package multibootusb-git...
:: Downloading the latest sources for a devel package gnome-shell-extension-arch-update-git...
:: Downloading the latest sources for a devel package gnome-shell-extension-dash-to-dock-git...
:: Downloading the latest sources for a devel package localtime-git...
:: Downloading the latest sources for a devel package gnome-shell-extension-extended-gestures-git...
:: Downloading the latest sources for a devel package vkquake-git...
:: Downloading the latest sources for a devel package gnome-shell-extension-freon-git...
:: Downloading the latest sources for a devel package gnome-shell-extension-openweather-git...
:: Downloading the latest sources for a devel package numix-icon-theme-git...
...
:: Starting full system upgrade...
resolving dependencies...
looking for conflicting packages...
...
Found snapshot: 2020-11-17 14:10:41 | @snapshots/root/965/snapshot        | post | libinput-gestures
Found snapshot: 2020-11-17 14:10:39 | @snapshots/root/964/snapshot        | pre  | pacman --color=always --upgrade --needed /home/user/.cache/pikaur/pkg/libinput-gestures-2.53-1-any....
Found snapshot: 2020-11-17 14:10:24 | @snapshots/root/963/snapshot        | post | adobe-source-code-pro-fonts firefox geoip-database haskell-adjunctions haskell-aeson haskell-ansi-te...
Found snapshot: 2020-11-17 14:09:53 | @snapshots/root/962/snapshot        | pre  | pacman --color=always --sync --needed --sysupgrade --ignore numix-circle-icon-theme-git --ignore plo...
...

pacman.log

...
[2020-11-17T14:07:05+0100] [PACMAN] Running 'pacman --color=always --sync --refresh'
...
[2020-11-17T14:07:47+0100] [PACMAN] Running 'pacman --color=always --sync --needed --sysupgrade --ignore numix-circle-icon-theme-git --ignore plotinus-git --ignore macchiato-git --ignore gnome-shell-extension-shelltile-git --ignore gnome-shell-extension-sound-output-device-chooser-git --ignore rhythmbox-plugin-alternative-toolbar-git --ignore materia-theme-git --ignore wat-git --ignore gnome-shell-extension-gtile-git --ignore numix-circle-arc-icons-git --ignore multibootusb-git --ignore gnome-shell-extension-arch-update-git --ignore gnome-shell-extension-dash-to-dock-git --ignore localtime-git --ignore gnome-shell-extension-extended-gestures-git --ignore vkquake-git --ignore gnome-shell-extension-freon-git --ignore gnome-shell-extension-openweather-git --ignore numix-icon-theme-git --ignore gnome-shell-extension-caffeine-git'
...
[2020-11-17T14:10:39+0100] [PACMAN] Running 'pacman --color=always --upgrade --needed /home/user/.cache/pikaur/pkg/libinput-gestures-2.53-1-any.pkg.tar.zst'
actionless commented 3 years ago

please attach the full log with --pikaur-debug flag as advised in issue template

actionless commented 3 years ago

ah, nevermind, i've got what the issue is about:

1) when aur package is ignored (because it's up to date as in your case, or because https://github.com/actionless/pikaur/issues/446) it needs to be ignored from upgrade

2) because pikaur have common internal ignore list for both aur and repo packages, those packages are also ignored from repo upgrade