search

actions-hub / gcloud

GitHub Action for interacting with Google Cloud Platform (GCP)
https://github.com/marketplace/actions/google-cloud-platform-gcp-cli-gcloud
MIT License
229 stars 28 forks source link

Check on base64 encoding incorrect #15

Closed jdewinne closed 4 years ago

jdewinne commented 4 years ago

https://github.com/actions-hub/gcloud/blob/master/entrypoint.sh#L16

Should become:

if [ "$(echo "$APPLICATION_CREDENTIALS" | tr -d \\n)" = "$(echo "$APPLICATION_CREDENTIALS" | base64 -d | base64  | tr -d \\n)" ]; then
exelban commented 4 years ago

Merged, thanks