Question about PROJECT_ID parameter

actions-hub / gcloud

GitHub Action for interacting with Google Cloud Platform (GCP)

https://github.com/marketplace/actions/google-cloud-platform-gcp-cli-gcloud

MIT License

229 stars 28 forks source link

Question about PROJECT_ID parameter #22

Closed HaveF closed 3 years ago

HaveF commented 3 years ago

Thanks for this repo!

About

PROJECT_ID - must be provided to activate a specific project.

Do we really need this? In service account(json), it already has project_id in it?

exelban commented 3 years ago

Hi.

I remember that there was some problem with this. But now I'm not sure why I decided to make it as env. In theory, it could be changed. I don't when I will have free time to add this option.

But I always glad for PR)

HaveF commented 3 years ago

A quick view about the logic.

It seems related with PREVIOUS_PROJECT_ID thing, OK, let it be.

Thanks