search

actions-js / push

⬆️ Push changes made by actions right back into the current repository.
MIT License
87 stars 50 forks source link

Node.js 12 actions are deprecated #11

Closed devenes closed 1 year ago

devenes commented 1 year ago

The GitHub Actions workflow gives the following annotation while running the action.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-js/push

devenes commented 1 year ago

The pull request has been opened: #10

notfilippo commented 1 year ago

Closed by #10

bhrajesh97 commented 1 year ago

i'm create git to cpnale cicd and i don't know it working but i'm sacing thiss issue can you pleqase help me Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: bhrajesh97/deployer@4.3.0

devenes commented 1 year ago

Hi @bhrajesh97,

i'm create git to cpnale cicd and i don't know it working but i'm sacing thiss issue can you pleqase help me Node.js 12 actions are deprecated. For more information see: github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12. Please update the following actions to use Node.js 16: bhrajesh97/deployer@4.3.0

It looks like it is already updated to v16, (https://github.com/bhrajesh97/deployer/commit/c7d02ea518fde94aa77e5c9347e9c07cbcdbe739) you can get a new release to use or you can use bhrajesh97/deployer@master since it committed in the master branch.

thomasmerz commented 1 year ago

@notfilippo , can you please give the community a new release? Thanks a lot!

ReenigneArcher commented 1 year ago

Anything preventing a new release? This would be nice to have updated as I have a lot of workflows to get updated, as I'm sure many others do.

devenes commented 1 year ago

@notfilippo 👆

notfilippo commented 1 year ago

Released! Sorry for the wait @devenes @ReenigneArcher @thomasmerz

devenes commented 1 year ago

Thank you 🎉 @notfilippo

JamesVanWaza commented 1 year ago

@notfilippo, @devenes if I get the error, and the firebase-hosting-merge.yml and firebase-hosting-pull-request.yml is autogenerated, how do I fix it?

devenes commented 1 year ago

Hi @JamesVanWaza,

I checked your repositories and found that you are using some old version actions. You need to upgrade the version of the action:

Actually there is no new release of FirebaseExtended/action-hosting-deploy action so you can specify the branch name with using: - uses: FirebaseExtended/action-hosting-deploy@main

You can check my PR according the issue: https://github.com/JamesVanWaza/algolia-instantsearch-demo/pull/367

JamesVanWaza commented 1 year ago

Great just saw your PR. Will update them manually. Once the new release is out let us know.

devenes commented 1 year ago

I just realized that they updated the release with the action upgrade commit: https://github.com/FirebaseExtended/action-hosting-deploy/releases/tag/v0. So there is no problem about using v0. Your error must be because the checkout action.