Open 2m opened 4 years ago
@proppy can you evaluate this?
As mentioned in https://github.com/actions-on-google/actions-on-google-java/issues/30#issuecomment-644234766, I think we should consider tying the lifecycle of the channel to SmartHomeApp
.
Should we split the fix to CONTRIBUTING.md
in a separate pull request?
Sounds good. I will split changes to CONTRIBUTING.md
to a separate PR and also will rework this PR so the lifecycle of the channel is tied to SmartHomeApp.
@2m just a related note that we are also considering removing this homegraph wrapper altogether in favor of having developer depends directly on the generated homegraph bindings: https://github.com/googleapis/google-api-java-client-services/tree/master/clients/google-api-services-homegraph/v1
I'd be curious to hear your thoughts.
looks like the link of bintray is unavailable
> Could not resolve com.google.actions:actions-on-google:1.8.0-2m.
> Could not get resource 'http://dl.bintray.com/2m/maven/com/google/actions/actions-on-google/1.8.0-2m/actions-on-google-1.8.0-2m.pom'.
> Could not GET 'http://dl.bintray.com/2m/maven/com/google/actions/actions-on-google/1.8.0-2m/actions-on-google-1.8.0-2m.pom'.
> dl.bintray.com:80 failed to respond
I added like described in the build Gradle file
repositories {
maven {
url 'http://dl.bintray.com/2m/maven'
}
mavenCentral()
jcenter()
}
dependencies {
implementation 'com.google.actions:actions-on-google:1.8.0-2m'
}
Anyway, where can I edit that SmartHomeApp.kt file, I can't find it anywhere
looks like the link of bintray is unavailable
Yea, bintray was shutdown since then.
I stopped working on this PR since I am not using this project anymore in my home automation.
Feel free to take it over.
This fixes the following errors from the logs:
This fix was originally mentioned in https://github.com/actions-on-google/actions-on-google-java/issues/30#issuecomment-529400776
I have also published this change to my bintray repository so I can use this fix in https://github.com/actions-on-google/smart-home-java
If anyone else is interested, you can also use it by adding the following to the gradle build: