actions-on-google / actions-on-google-java

Java/Kotlin library for Actions on Google
Apache License 2.0
287 stars 39 forks source link

why there is no field `notificationSupportedByAgent` ? #62

Open feihu-wyze opened 3 years ago

feihu-wyze commented 3 years ago

https://github.com/actions-on-google/actions-on-google-java/blob/3d9f62beb8a8ff98844528badcea9ebaaed559cc/src/main/proto/google/home/graph/v1/device.proto#L27

c0010c commented 2 years ago

I have the same problem.

jerrymhlee commented 2 years ago

Please use HomeGrph API instead. https://github.com/googleapis/google-api-java-client-services/tree/main/clients/google-api-services-homegraph/v1

feihu-wyze commented 2 years ago

Please use HomeGrph API instead. https://github.com/googleapis/google-api-java-client-services/tree/main/clients/google-api-services-homegraph/v1

Thanks, but it needs a lot of changes

joerijansen commented 1 year ago

Fine with me to use the HomeGrph API, but then, why does the Java example on https://developers.home.google.com/samples?language=java point to the usage of this library? As indicated by @feihu-wyze , changing to HomeGrph is a major change. Fixing this issue in this library is only a minor adjustment and would help a lot...