actions-on-google / actions-on-google-nodejs

Node.js client library for Actions on Google
https://actions-on-google.github.io/actions-on-google-nodejs
Apache License 2.0
900 stars 197 forks source link

Failed Media_Response results in follow up intent not being able to be triggered #386

Open hausbergeranna opened 4 years ago

hausbergeranna commented 4 years ago

I am implementing a Google Action, which will play certain songs, and you can play a song by saying "Play song X" and go to the next or previous song with commands like "Previous song"/"Next song", these two intents (next and previous) are follow up intents from the play-intent.
The problem I am facing is, that some files are damaged from the database or the fromat is not supported (I can not influence that) and of course it will then be displayed in the Google Assistant that this file is not playable, which is what I expected, but then if I enter the command "Next song" it will be stuck in an endless loop, it didn't even send a request (looked at logs in firebase), it just shows the loading spinner forever.
Other intents, which are not a follow up intent, work in this case, only calling those two follow-up intents will result in NO request sent and endless spinning.
Also, it would be nice, if we could get the MEDIA_STATUS FAILED to add custom handeling or to track the not working files.