actions-on-google / actions-on-google-nodejs

Node.js client library for Actions on Google
https://actions-on-google.github.io/actions-on-google-nodejs
Apache License 2.0
900 stars 197 forks source link

Upgrade "google-auth-library" dependency to latest major version #432

Open meteohr opened 2 years ago

meteohr commented 2 years ago

In our project, we have both actions-on-google (v3.0.0) and google-auth-library (v8.0.3) as dependencies. Because actions-on-google relies on google-auth-library ^7.2.0, we get a typescript error in our project:

TS2769: No overload matches this call.
Overload 1 of 2, '(version: "v1"): Homegraph', gave the following error.
Argument of type '{ version: string; auth: GoogleAuth<JSONClient>; }' is not assignable to parameter of type '"v1"'.   Overload 2 of 2, '(options: Options): Homegraph', gave the following error.
Type 'GoogleAuth<JSONClient>' is not assignable to type 'string | BaseExternalAccountClient | GoogleAuth<JSONClient> | OAuth2Client | undefined'.
Type 'import("/Users/theUser/workspace/the-project/node_modules/google-auth-library/build/src/auth/googleauth").GoogleAuth<import("/Users/theUser/workspace/the-project/node_modules/google-auth-library/build/src/auth/googleauth").JSONClient>' is not assignable to type 'import("/Users/theUser/workspace/the-project/node_modules/actions-on-google/node_modules/google-auth-library/build/src/auth/googleauth").GoogleAuth<import("/Users/theUser/workspace/the-project/node_modules/actions-on-google/node_modules/google-auth-library/build/src/auth/googleauth").JSONClient>'.
Types have separate declarations of a private property 'checkIsGCE'.

I would kindly ask to upgrade the google-auth-library to the latest dependency and release a new version of this package to npm. I tested this locally and it seems to work without any manual changes needed.