Support i18n. - Githubissues

actions-on-google / actions-on-google-testing-nodejs

Apache License 2.0

75 stars 18 forks source link

Support i18n. #1

Closed yoichiro closed 6 years ago

yoichiro commented 6 years ago

Fix #2.

What is this

To fix #2, I would like to introduce the mechanism to support i18n.

How to introduce the mechanism

Introduce the i18n library to construct phrases for each language (here).
Define each phrase in message resource bundle files. They are created for each language in the locales directory (here).
Construct a phrases to invoke the action using the i18n mechanism (here).

yoichiro commented 6 years ago

@Fleker I pushed some commits to improve some codes and to support languages. The points are the following:

Improved the format of each invocation phrase to start a conversation. For instance, the app name is embed with {{app_name}} in each message. Please see 02616d3
Added a logic to throw an exception when an invalid locale string passed to the setLocale function. Please see the code.
Add message bundle files to define all supported languages (based on the Language and Locale Support page). Please see 48c0e34.

Could you review them above again?

yoichiro commented 6 years ago

@Fleker Thank you for the comments. I changed some codes according to your advices:

Output a warning message when unsupported language is specified, instead of throwing an exception. See: f58ade3
Remove the unnecessary semi-colon character. See: 38fcb54

Could you review them?

Fleker commented 6 years ago

As an FYI, I submitted your PR but then also had been moving the library to Typescript, so I had to do some restructuring of the commits for the changes to merge correctly.

yoichiro commented 6 years ago

@Fleker Oh, sorry about that. Have you already done the restructuring? If no, I can help you and the task. Feel free to let me know that. Thanks!