search

actions-on-google / actions-on-google-testing-nodejs

Apache License 2.0
75 stars 18 forks source link

Change the license notation in the package.json file. #12

Closed yoichiro closed 6 years ago

yoichiro commented 6 years ago

We need to use the short identifier defined by the SPDX in the package.json file. For instance, the short identifier for Apache License 2.0 is Apache-2.0 (see).

Currently, when executing yarn build and so on, the following warning message will be output:

$ yarn build
yarn run v1.7.0
warning package.json: License should be a valid SPDX license expression
$ tsc && cp -r ./locales ./dist
✨  Done in 4.32s.

I would like to fix this issue by this pull request. Could you review this?

yoichiro commented 6 years ago

@Fleker @Canain Could you review this pull request?

Fleker commented 6 years ago

Yeah I've been meaning to go back to this change. It looks good to me. I think I originally took this from one of the other packages we have. Maybe we should adopt some automated way to validate the notation.