search

actions-on-google / actions-on-google-testing-nodejs

Apache License 2.0
75 stars 18 forks source link

Fix the MediaObject icon/largeImage issue #25

Closed yoichiro closed 6 years ago

yoichiro commented 6 years ago

Fix the #24

What is this pull request

This pull request has a fix code to resolve the issue #24. The current code expects that each MediaObject object has an icon value including the url child value. However, it is possible to specify a largeImage value, instead of the icon value in the specification of the MediaObject.

Both the icon and the largeImage must be applied. This pull request changes the code to apply both them.

How to change the code

Currently, the icon property is required. I would like to change that the icon property is optional. In addition, I would like to add a new property called largeImage to the mediaResponse interface definition. Of course, the largeImage is also optional.

yoichiro commented 6 years ago

@Fleker Could you review this pull request?

yoichiro commented 6 years ago

@atulep It would be great if you review this pull request. Thank you.

yoichiro commented 6 years ago

@atulep I changed both the icon and largeImage as optional at 83de6b4. Could you check them again?

Fleker commented 6 years ago

Thanks a lot for taking care of this issue!