Closed pdtyreus closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
Googlers can find more info about SignCLA and this PR by following this link.
Sorry for the mess here. I had to amend the author email because of the CLA issue. I have signed the CLA with the email used in the last commit. So I'm just going to leave this alone until I get more guidance.
Hey @pdtyreus the change looks good, but we'll still require the CLA to be signed, or maybe resigned, before this can be merged.
I had a corporate CLA on file. Just created a personal version also. Maybe that will do the trick.
Thanks!
Since
displayText
is initialized to[]
the expression!assistResponse.displayText
will always be false. This prevents having thetextToSpeech
array take the value ofdata.dialog_state_out.supplemental_display_text
as desired.This likely contributes to issue #29