actions-on-google / actions-on-google-testing-nodejs

Apache License 2.0
75 stars 18 forks source link

include supplemental_display_text in textToSpeech #32

Closed pdtyreus closed 5 years ago

pdtyreus commented 5 years ago

Since displayText is initialized to [] the expression !assistResponse.displayText will always be false. This prevents having the textToSpeech array take the value of data.dialog_state_out.supplemental_display_text as desired.

This likely contributes to issue #29

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Googlers can find more info about SignCLA and this PR by following this link.

pdtyreus commented 5 years ago

Sorry for the mess here. I had to amend the author email because of the CLA issue. I have signed the CLA with the email used in the last commit. So I'm just going to leave this alone until I get more guidance.

Fleker commented 5 years ago

Hey @pdtyreus the change looks good, but we'll still require the CLA to be signed, or maybe resigned, before this can be merged.

pdtyreus commented 5 years ago

I had a corporate CLA on file. Just created a personal version also. Maybe that will do the trick.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Fleker commented 5 years ago

Thanks!