search

actions-on-google / actions-on-google-testing-nodejs

Apache License 2.0
75 stars 18 forks source link

Support additional intents #36

Closed adamcohenrose closed 5 years ago

adamcohenrose commented 5 years ago

We use the SIGN_IN and NEW_SURFACE intents in our action, so this change enables us to test that we're returning them at the right times.

I've also updated the dependencies to the latest versions to fix the audit warnings that were coming up all the time.

(fixed PR from https://github.com/actions-on-google/actions-on-google-testing-nodejs/pull/35)

adamcohenrose commented 5 years ago

Split into two separate PRs if you'd prefer: https://github.com/actions-on-google/actions-on-google-testing-nodejs/pull/38 and https://github.com/actions-on-google/actions-on-google-testing-nodejs/pull/39

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

adamcohenrose commented 5 years ago

argh - committed a change using the wrong email address again... please use the other PRs