search

actions-on-google / actions-on-google-testing-nodejs

Apache License 2.0
75 stars 18 forks source link

Additional modes #39

Closed adamcohenrose closed 5 years ago

adamcohenrose commented 5 years ago

Requires Node 8, but since Node 6 has reached end of life, most npm libraries should now require Node 8.

adamcohenrose commented 5 years ago

Good suggestion -- moved the intent names to consts

Yes, I have tested this in integration tests against our action -- it works fine :-)

Fleker commented 5 years ago

LGTM, but can you now rebase?

adamcohenrose commented 5 years ago

done. ready to merge

Fleker commented 5 years ago

Thanks!

adamcohenrose commented 5 years ago

Thanks for the merge :-)

Any chance of a release? I can't figure out how to depend on the github master directly since the library needs to be built before it can be used.

Fleker commented 5 years ago

Yeah I think releasing after the weekend would work best.

adamcohenrose commented 5 years ago

@Fleker I'd really appreciate a release -- I want to improve our functional tests and due to the way this project is built, I can't depend on the github from npm :-(

Is there a way to depend on a project of this style from github without waiting for a release?

Fleker commented 5 years ago

v0.3.0 is published!