Fix some compile errors.

actions-on-google / actions-on-google-testing-nodejs

Apache License 2.0

75 stars 18 forks source link

Fix some compile errors. #5

Closed yoichiro closed 6 years ago

yoichiro commented 6 years ago

The pull request #1 has diffs to support i18n written by JavaScript. But, the original code set was re-written by TypeScript. It seems that the merging #1 was not enough to migrate JavaScript to TypeScript, therefore, some compile errors occur.

By this pull request, I would like to fix the compile errors. Also, it is necessary to copy the locales directory to the dist directory where compiled files are put, thus, I would like to add the cp command to the build command.

yoichiro commented 6 years ago

@Fleker Could you review this pull request?

Fleker commented 6 years ago

Thanks for making these adjustments.

yoichiro commented 6 years ago

I modified some lines at f6f53c0:

Change to the setLocale instead of the locale property in the example code: here
Introduce the type definition for the i18n JavaScript library: here
Change to the import from require to load the i18n module: here
Use the type i18n.Replacements instead of the raw type definition {[key: string]: string;}: here

@Fleker @atulep Could you review them again?